Skip to content

Conversation

@ayush-panta
Copy link
Contributor

Description of changes: Upgraded golang.org/x/crypto v0.38.0 → v0.46.0 and containernetworking/plugins v1.7.1 → v1.9.0 to fix vulnerabilities flagged by dependabot. Got latest go versions for these then ran go mod tidy to sync deps. go build works.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ayush-panta ayush-panta requested a review from a team as a code owner December 23, 2025 20:27
sondavidb
sondavidb previously approved these changes Dec 23, 2025
@Kern--
Copy link
Contributor

Kern-- commented Dec 24, 2025

I think the best path forward for this is to skip the failing test when testing against upstream.

The bug is that Firecracker opens the metrics fifo with O_NONBLOCK. They used to open it with read/write, but now they open with write only. Opening a fifo with write only and O_NONBLOCK returns ENXIO. It used to work because of a non-standard linux thing where opening with read/write satisfied the kernel that nonblocking write was fine because there's a reader too.

We can ask firecracker to open with read/write again to fix it. Fixing it on our end looks tough because we create the metrics fifo as part of the API that starts the vm, but we can't start the vm unless something is reading the fifo.

We probably had a potential metrics/log loss here anyway if you don't open the fifo fast enough and the fifo buffer fills.

EDIT: To be clear, fc-go-sdk does not work with upstream firecracker when using metrics fifos instead of metrics files. We need to do something about that, but we should be able to merge dependencies in the meantime.

@ayush-panta ayush-panta merged commit 6fb280e into firecracker-microvm:main Dec 24, 2025
18 checks passed
@ayush-panta ayush-panta deleted the fix-deps branch December 24, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants