Tracing fix #4283
Merged
Tracing fix #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4283 +/- ##
=======================================
Coverage 81.69% 81.69%
=======================================
Files 240 240
Lines 29293 29293
=======================================
Hits 23932 23932
Misses 5361 5361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JonathanWoollett-Light
force-pushed
the
tracing-fix
branch
3 times, most recently
from
e335299
to
4749500
Compare
JonathanWoollett-Light
force-pushed
the
tracing-fix
branch
from
4749500
to
d8e9b8b
Compare
JonathanWoollett-Light
added
the
Status: Awaiting review
ShadowCurse
previously approved these changes
Nov 29, 2023
kalyazin
reviewed
Nov 29, 2023
JonathanWoollett-Light
force-pushed
the
tracing-fix
branch
from
d8e9b8b
to
3db68a1
Compare
JonathanWoollett-Light
force-pushed
the
tracing-fix
branch
2 times, most recently
from
465b86d
to
4031128
Compare
added 2 commits
November 30, 2023 15:46
Improves tracing documentation. Signed-off-by: Jonathan Woollett-Light <[email protected]>
When running `cargo build --features tracing` with `src/utils` instrumented errors are produced due to the `log-instrument` optional dependency not being enabled by the `utils/tracing` feature. This commit makes the dependency non-optional to fix this, when unneeded the dependency will still be ommited at compile time however this may very slightly increase compile time. Signed-off-by: Jonathan Woollett-Light <[email protected]>
JonathanWoollett-Light
force-pushed
the
tracing-fix
branch
from
2beab45
to
5d7e75c
Compare
kalyazin
approved these changes
Nov 30, 2023
ShadowCurse
approved these changes
Nov 30, 2023
JonathanWoollett-Light
merged commit e03ae44
into
firecracker-microvm:main
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improves tracing documentation and fixes dependency issue.
Reason
When running
cargo build --features tracingwithsrc/utilsinstrumented errors are produced due to the optional dependency not
being enabled. This makes the dependency non-optional to fix this, when
unneeded the dependency will still be ommited at compile time however
this may very slightly increase compile time.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.