Add VIRTIO_NET_F_MRG_RXBUF to virtio-net #4834
Merged
+372
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2024
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
8 times, most recently
from
7cad4af
to
97f33c2
Compare
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
from
97f33c2
to
898a0aa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4834 +/- ##
==========================================
+ Coverage 84.01% 84.05% +0.04%
==========================================
Files 251 251
Lines 28019 28061 +42
==========================================
+ Hits 23541 23588 +47
+ Misses 4478 4473 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
from
898a0aa
to
59d517a
Compare
roypat
reviewed
Oct 7, 2024
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
6 times, most recently
from
8190129
to
7bf4b03
Compare
ShadowCurse
added
Type: Enhancement
roypat
reviewed
Oct 14, 2024
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
from
7bf4b03
to
6c271b6
Compare
bchalios
requested changes
Oct 14, 2024
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
2 times, most recently
from
f23d061
to
7e767b7
Compare
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
6 times, most recently
from
e825696
to
9446de2
Compare
bchalios
previously approved these changes
Oct 15, 2024
roypat
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Do we have any unittests where we explicitly test functionality that's special to mergeable buffers? E.g I see that we extended a bunch of the existing tests to make sure those cases still work for mergeable buffers, but do we have anything where we construct a chain that would be invalid without mergbuf, but can be processed with the feature?
kalyazin
reviewed
Oct 15, 2024
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
from
0f5b179
to
0f6fe4c
Compare
`Queue::add_used()` method first writes a Descriptor head in the used descriptor ring buffer and then advances the index of this buffer to let the guest know we used one or more Descriptors. Carve out each one of these steps in their own function so that we can add multiple descriptors in the used ring and advance the index only once we finish handling descriptors in one step. This will be useful when, in later commits, we will implement VIRTIO_NET_F_RX_MRGBUF for the RX queue of the network device. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
2 times, most recently
from
219941b
to
c6142c0
Compare
bchalios
requested changes
Oct 15, 2024
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
from
c6142c0
to
0d8716f
Compare
bchalios
reviewed
Oct 15, 2024
bchalios
reviewed
Oct 15, 2024
bchalios
reviewed
Oct 15, 2024
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
2 times, most recently
from
b0363f2
to
f07cbf0
Compare
Implement VIRTIO_NET_F_MRG_RXBUF feature for VirtIO network device. It allows receiving a single network frame into multiple descriptor chains. The amount of descriptor chains (also known as heads) that were used is written into the `virtio_net_hdr_v1` structure which is located at the beginning of the guest buffer. Signed-off-by: Egor Lazarchuk <[email protected]>
Add a note about new `VIRTIO_NET_F_RX_MRGBUF` feature in the virtio-net device. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
bchalios_readv_mrg_buf
branch
from
f07cbf0
to
e4fd753
Compare
bchalios
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add VIRTIO_NET_F_MRG_RXBUF to virtio-net.
Now virtio-net device can split incoming packets across multiple descriptor chains if VIRTIO_NET_F_MRG_RXBUF is enabled by the guest.
Reason
Improves performance of virtio-net device.
Fixes: #1314
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.