feat: AMD support larger extended function entries #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4995 +/- ##
==========================================
- Coverage 83.20% 83.20% -0.01%
==========================================
Files 247 247
Lines 26639 26631 -8
==========================================
- Hits 22166 22158 -8
Misses 4473 4473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JackThomson2
force-pushed
the
feat/amd_extended_fn_range_support
branch
2 times, most recently
from
2469548 to
38300e6
Compare
JackThomson2
force-pushed
the
feat/amd_extended_fn_range_support
branch
2 times, most recently
from
dabc490 to
b4dfe07
Compare
roypat
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
roypat
previously approved these changes
Feb 19, 2025
kalyazin
reviewed
Feb 19, 2025
JackThomson2
force-pushed
the
feat/amd_extended_fn_range_support
branch
2 times, most recently
from
5a27b3d to
712dde5
Compare
roypat
reviewed
Feb 19, 2025
Removed the extended function entry normalisation step from AMD CPUs. We will now pass through the value provided by KVM or set through a CPU template. This now mirrors the behaviour of Intel. On newer AMD chips and newer kernels we are now able to pass through features which were previously out of range. Signed-off-by: Jack Thomson <[email protected]>
JackThomson2
force-pushed
the
feat/amd_extended_fn_range_support
branch
from
712dde5 to
10049e6
Compare
Add entry for the removal of extended function entry normalisation. Signed-off-by: Jack Thomson <[email protected]>
JackThomson2
force-pushed
the
feat/amd_extended_fn_range_support
branch
from
10049e6 to
426eed6
Compare
roypat
approved these changes
Feb 21, 2025
kalyazin
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.