Skip to content

Conversation

@kalyazin
Copy link
Contributor

@kalyazin kalyazin commented Jan 13, 2026

Changes

Update KVM flags and caps

Reason

According to the last update of kernel patches (#5620).
Also update the error write() emites if it's asked to populate a page not in direct map from ENOSPACE to EEXIST.
Also backport #5614 .

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.31%. Comparing base (4ab5b2b) to head (ef1f55f).
⚠️ Report is 2 commits behind head on feature/secret-hiding.

Files with missing lines Patch % Lines
src/vmm/src/builder.rs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/secret-hiding    #5622      +/-   ##
=========================================================
- Coverage                  82.35%   82.31%   -0.05%     
=========================================================
  Files                        277      277              
  Lines                      29900    29903       +3     
=========================================================
- Hits                       24625    24615      -10     
- Misses                      5275     5288      +13     
Flag Coverage Δ
5.10-m5n.metal 82.42% <0.00%> (-0.02%) ⬇️
5.10-m6a.metal 81.72% <0.00%> (-0.03%) ⬇️
5.10-m6g.metal 79.30% <0.00%> (-0.01%) ⬇️
5.10-m6i.metal 82.42% <0.00%> (-0.02%) ⬇️
5.10-m7a.metal-48xl 81.72% <0.00%> (-0.03%) ⬇️
5.10-m7g.metal 79.30% <0.00%> (-0.01%) ⬇️
5.10-m7i.metal-24xl 82.38% <0.00%> (-0.03%) ⬇️
5.10-m7i.metal-48xl 82.39% <0.00%> (-0.02%) ⬇️
5.10-m8g.metal-24xl 79.30% <0.00%> (-0.01%) ⬇️
5.10-m8g.metal-48xl 79.30% <0.00%> (-0.01%) ⬇️
6.1-m5n.metal 82.44% <0.00%> (-0.07%) ⬇️
6.1-m6a.metal 81.75% <0.00%> (-0.03%) ⬇️
6.1-m6g.metal 79.30% <0.00%> (-0.01%) ⬇️
6.1-m6i.metal 82.44% <0.00%> (-0.03%) ⬇️
6.1-m7a.metal-48xl 81.74% <0.00%> (-0.03%) ⬇️
6.1-m7g.metal 79.30% <0.00%> (-0.01%) ⬇️
6.1-m7i.metal-24xl 82.45% <0.00%> (-0.04%) ⬇️
6.1-m7i.metal-48xl 82.45% <0.00%> (-0.03%) ⬇️
6.1-m8g.metal-24xl 79.30% <0.00%> (-0.01%) ⬇️
6.1-m8g.metal-48xl 79.30% <0.00%> (-0.01%) ⬇️
6.17-m5n.metal ?
6.17-m6a.metal ?
6.17-m6g.metal ?
6.17-m6i.metal ?
6.17-m7a.metal-48xl ?
6.17-m7g.metal ?
6.17-m7i.metal-24xl ?
6.17-m7i.metal-48xl ?
6.17-m8g.metal-24xl ?
6.17-m8g.metal-48xl ?
6.18-m5n.metal 82.44% <0.00%> (?)
6.18-m6a.metal 81.75% <0.00%> (?)
6.18-m6g.metal 79.30% <0.00%> (?)
6.18-m6i.metal 82.44% <0.00%> (?)
6.18-m7a.metal-48xl 81.74% <0.00%> (?)
6.18-m7g.metal 79.30% <0.00%> (?)
6.18-m7i.metal-24xl 82.45% <0.00%> (?)
6.18-m7i.metal-48xl 82.45% <0.00%> (?)
6.18-m8g.metal-24xl 79.30% <0.00%> (?)
6.18-m8g.metal-48xl 79.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalyazin kalyazin force-pushed the int_sh_2026-01-12_dmr_v9_on_6.18 branch 2 times, most recently from 9c9565b to ed395b9 Compare January 13, 2026 17:32
kalyazin and others added 2 commits January 14, 2026 08:18
According to the last update of kernel patches.
Also update the error write() emites if it's asked to populate a page
not in direct map from ENOSPC to EEXIST.

Signed-off-by: Nikita Kalyazin <[email protected]>
In order to prevent future `cargo-audit` failures of reading new
new security database disclosures, remove `cargo-audit` from dev
container and always try to install `cargo-audit` from source
instaed. This makes CI always use new version of the binary while for
normal development, local version will be used (so no `--force` flag).

(cherry picked from commit d61e343)
Signed-off-by: Egor Lazarchuk <[email protected]>
@kalyazin kalyazin force-pushed the int_sh_2026-01-12_dmr_v9_on_6.18 branch from ed395b9 to ef1f55f Compare January 14, 2026 08:19
@kalyazin kalyazin marked this pull request as ready for review January 14, 2026 09:05
@kalyazin kalyazin merged commit 1f6b20b into firecracker-microvm:feature/secret-hiding Jan 14, 2026
5 of 7 checks passed
@kalyazin kalyazin deleted the int_sh_2026-01-12_dmr_v9_on_6.18 branch January 14, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants