Add building with Podman managed containers #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add Makefile target build-in-podman. 2. Update README.md. 3. Add gitignore .vscode. Signed-off-by: Mark Van de Vyver <[email protected]>
kzys
suggested changes
Apr 9, 2020
| @@ -1,2 +1,3 @@ | |||
| firectl | |||
| firectl.sha256 | |||
| .vscode | |||
There was a problem hiding this comment.
For editor-specific files, I think it would be better to use a per-user global gitignore file.
Comment on lines
+22
to
+23
| 1. `make build-in-docker` | ||
| 1. `make build-in-podman` |
There was a problem hiding this comment.
How about using * instead? People may see the instruction as "First make build-in-docker, then make build-in-podman", but the intention here is OR, not AND.
* `make build-in-docker`
* `make build-in-podman`
There was a problem hiding this comment.
Good point:
* `make build-in-docker`, or
* `make build-in-podman`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #53: Support building with Podman: make build-in-podman
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.