This repository was archived by the owner on Jul 20, 2020. It is now read-only.
Added 'uv' and 'groups' support to BufferGeometryDescriptor #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR :) I think we may need to test to see what happens if for example 3 groups are used first and then that's changed to 2 groups, but I can do that in the merge branch, I think I get the main idea of the PR already :D |
|
Excellent, i'm more concerned about UVs than groups, if you want i can separate that in couple of PRs |
|
Yes having a separate PR for them will make it easier to press the merge button :) |
|
Should keep the PRs against master or do you have a development branch? |
|
Master is good |
|
I'll add in |
toxicFork
added a commit
that referenced
this pull request
Nov 10, 2017
|
Yes thanks, sorry for not separating the PRs, project's taking all my time and i have it 'npm link' on my rig X-D |
|
Don't worry, I have similar issues :D we need an open source support group
…On Fri, 10 Nov 2017, 11:51 Chiguireitor, ***@***.***> wrote:
Yes thanks, sorry for not separating the PRs, project's taking all my time
and i have it 'npm link' on my rig X-D
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#194 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0iLVSjq6g8h-TyVpPgja72DTblQNB-ks5s1DjYgaJpZM4PQV9F>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork/branch adds the possibility to use BufferGeometry with UVs and Groups (although assigning different materials for each group is another story).