refactor: change Sessions::create_with to take SessionPlugin #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a closer look soon - I think the idea makes sense though. |
|
@zicklag yeah I think this is the right way to do it - will PR an update to jumpy + bones_volleyball to match this. |
MaxCWhitehead
approved these changes
Jun 19, 2025
Opened PR for jumpy fishfolk/jumpy#1050 (should be safe to merge before this PR going through / bones update) - and bones_volleyball already seems to have the type annotations. |
zicklag
force-pushed
the
fix-create_with
branch
2 times, most recently
from
5755b89 to
8c441c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR for @TekhnaeRaav, but I'm not sure about this one yet, since it does require annotating the argument type when passing in a closure, which isn't as nice, even though it's more flexible because you can pass in any plugin.
I'm a little less acquainted with this API right now.
@MaxCWhitehead whenever you get the chance to take a peek at this I wonder if you have thoughts.