feat: add word-boundary guards for ASCII surfaces to prevent partial replacements#7
Open
pratik1258m wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #3 by introducing word-boundary guards (
\b) for ASCII surfaces during replacement. This improves precision for Latin text by ensuring literal substrings do not accidentally match and get replaced inside longer words (e.g. preventing 'Jack' from replacing inside 'jackpot' or 'hijack'). Chinese and other CJK text remain unaffected.Changes:
applymethod invaultengine/mapping.pyto check if the surface starts and ends with an ASCII word character, and if so, perform the replacement using a regular expression anchored by word boundaries (\b).tests/test_mapping.pyto verify that partial word replacements are prevented for ASCII surfaces while full word matches succeed and CJK replacements remain unaffected.