Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DownloadTimeout and Retry #91

Merged
merged 10 commits into from
Oct 23, 2023

Conversation

pawelvds
Copy link
Contributor

No description provided.

@pawelvds pawelvds linked an issue Jun 19, 2023 that may be closed by this pull request
@pawelvds pawelvds changed the title fefsf Implement DownloadTimeout and Retry Jun 19, 2023
@pawelvds pawelvds marked this pull request as ready for review June 23, 2023 08:54
@pawelvds pawelvds requested a review from a team June 23, 2023 08:54
@volllly
Copy link
Contributor

volllly commented Jun 27, 2023

I would love if we could refactor the creation of the policies here into a helper class.

https://github.com/fiskaltrust/middleware-launcher/pull/91/files#diff-5479e5559a7e6c816be57a02b080271ac8cabcefe6f9128bfcb51df9f92ee7a4R26-R32

https://github.com/fiskaltrust/middleware-launcher/pull/91/files#diff-0080b553315406d4c6b2c9e39533463df4ba95c04b740c6e7539397ea2b2fa8fR26-R32

something like this
src/fiskaltrust.Launcher/Helpers/PolicyHelper.cs

static class PolicyHelper {
  public static IAsyncPolicy<HttpResponseMessage> CreateHttpClientPolicy(Launcher
configuration configuration) {
    // create policy here
  }
}

and then in the dowloaders just do this _policy = PolicyHelper.CreateHttpClientPolicy(configuration);

@volllly volllly requested a review from a team as a code owner October 23, 2023 13:56
@pawelvds pawelvds merged commit d0eae7e into main Oct 23, 2023
15 checks passed
@pawelvds pawelvds deleted the implement-downloadtimeout-and-retry branch October 23, 2023 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DownloadTimeout and Retry
2 participants