Rename launcher scripts and fix download timeout handling. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of using the migration script the launcher .zip file is copied into the old launcher folder. since the
test.cmdscript already exists there in the old version it has to be overwritten and is then backed up as part of the old launcher files.To solve this we renamed the scripts in the new launcher to
launcher-*.cmd. As a plus this leads to them being next to each other in the file list when sorted alphabetically.We've also change the handling of the download timeout to not cancel the download if its already running but only when the connection is timing out.