Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy receipt changes to 1.3 #199

Merged
merged 68 commits into from
Oct 5, 2023
Merged

Copy receipt changes to 1.3 #199

merged 68 commits into from
Oct 5, 2023

Conversation

pawelvds
Copy link
Contributor

@pawelvds pawelvds commented Aug 21, 2023

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

{Summary of the changes}

Description

{Detail}

Fixes #{issue number}

@pawelvds pawelvds changed the title Init commit Copy receipt changes to 1.3 Aug 21, 2023
@pawelvds pawelvds marked this pull request as ready for review August 23, 2023 11:30
@pawelvds pawelvds requested a review from a team as a code owner August 23, 2023 11:30
Copy link
Contributor

@volllly volllly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing is the PopulateFtJournalFRCopyPayloadTable functionality.

I'd like that to happen when the Migration happens but we haven't done something similar before so theres no precendent how to do it 😅

Also when its done fot sqlite we'll need to add that functionality to the other storages aswell (I'd do that in the end).

volllly

This comment was marked as duplicate.

@volllly volllly merged commit 1a9abd8 into main Oct 5, 2023
10 checks passed
@volllly volllly deleted the add-copy-receipt-changes-to-1.3 branch October 5, 2023 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants