Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding interface v2 wrapper to AT, DE and FR #296

Merged
merged 132 commits into from
Jul 16, 2024
Merged

Conversation

LeilaZarban
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

{Summary of the changes}

Description

{Detail}

Fixes #{issue number}

@LeilaZarban LeilaZarban requested a review from a team as a code owner May 23, 2024 19:47
@volllly
Copy link
Contributor

volllly commented May 24, 2024

Something that we could also add to this package are extension methods for the ReceiptRequest and ReceiptResponse and ChargeItems and PayItems to get the value of all of these Flags 😅

At the moment we have multiple implementations of these extensions for the relevant flags in multiple of the projects in this repo and in the exports etc.
To reduce the duplication we could define them in this new package and reuse them everywhere.

  • Implement using source generators

@TSchmiedlechner TSchmiedlechner changed the title Interace.Tagging Addinv interface v2 wrapper to AT, DE and FR May 24, 2024
@TSchmiedlechner TSchmiedlechner changed the title Addinv interface v2 wrapper to AT, DE and FR Adding interface v2 wrapper to AT, DE and FR May 24, 2024
@forsthug forsthug merged commit a881cda into main Jul 16, 2024
9 checks passed
@LeilaZarban LeilaZarban deleted the Interface-Convertor branch July 16, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants