♻️ Lot of analyser fixes #399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenhobi
approved these changes
Sep 19, 2022
Comment on lines
129
to
+130
| input = Regex.Replace(input ?? "", @"\p{C}+", string.Empty); | ||
| return input.Trim().Length == 0 ? defaultValue : input.Substring(0, Math.Min(input.Length, 30)); | ||
| return input.Trim().Length == 0 ? defaultValue : input[..Math.Min(input.Length, 30)]; |
There was a problem hiding this comment.
This is really cool. Feels like python :D
| @@ -17,7 +17,7 @@ protected ActionResult Page(string message, int code) | |||
| { | |||
| Response.StatusCode = code; | |||
|
|
|||
| bool success = code >= 200 && code < 300; | |||
| bool success = code is >= 200 and < 300; | |||
stepech
reviewed
Sep 20, 2022
Comment on lines
32
to
+34
| var text = new StringBuilder("I picked: "); | ||
| var winNumber = random.Next(answers.Length); | ||
| var winner = answers[winNumber]; | ||
| int winNumber = random.Next(answers.Length); | ||
| string winner = answers[winNumber]; |
|
|
||
| var response = new DiscordInteractionResponseBuilder() | ||
| .WithTitle($"New Warning for {ctx.TargetMember.DisplayName}") | ||
| .WithCustomId(modalId) | ||
| .AddComponents(new TextInputComponent("Reason:", reasonId, required: true)); | ||
| await ctx.CreateResponseAsync(InteractionResponseType.Modal, response); | ||
|
|
||
| var numberOfWarnings = await _warningService.GetNumberOfWarnings(ctx.TargetUser.Id); | ||
| int numberOfWarnings = await _warningService.GetNumberOfWarnings(ctx.TargetUser.Id); |
| } | ||
| catch (NotFoundException) | ||
| {} | ||
| } |
There was a problem hiding this comment.
I am not sure if this change increases readability. There is also duplicite code now.
There was a problem hiding this comment.
Github changed it... This review was for the changes in the whole file StringExtensions.cs
| return null; | ||
|
|
||
| return GetDto(reminder); | ||
| return reminder == null ? null : GetDto(reminder); |
There was a problem hiding this comment.
Suggested change
| return reminder == null ? null : GetDto(reminder); | |
| return reminder is null ? null : GetDto(reminder); |
Comment on lines
+12
to
+16
| int encLen = (input.Length + 1) * 3; | ||
| var enc = encLen <= 1024 ? stackalloc byte[encLen] : new byte[encLen]; | ||
| Span<byte> bytes = stackalloc byte[256 / 8]; | ||
|
|
||
| var len = Encoding.UTF8.GetBytes(input, enc); | ||
| int len = Encoding.UTF8.GetBytes(input, enc); |
There was a problem hiding this comment.
Mixing diferent declaration types 😄
| return null; | ||
|
|
||
| return GetDto(warning); | ||
| return warning == null ? null : GetDto(warning); |
There was a problem hiding this comment.
Suggested change
| return warning == null ? null : GetDto(warning); | |
| return warning is null ? null : GetDto(warning); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a lot of fixes from the analyzer. I have only used the most relevant ones. There was also one nullable warning (in Poll.cs).