Skip to content

Conversation

@fivetran-savage
Copy link
Contributor

@fivetran-savage fivetran-savage commented Oct 29, 2025

PR Overview

Package version introduced in this PR:

  • 1.0.1

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • adds xero__calendar_start_date variable to allow customers to specify earlier start dates than the calendar spine default.
  • updates column name in vertical_general_ledger_tracking validation test to use tracking_option_name instead of the deprecated option column.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • [ ]
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-avinash fivetran-avinash added type:bug Something is broken or incorrect type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality and removed type:bug Something is broken or incorrect labels Oct 30, 2025
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-savage Approved with one small comment. This shouldn't require a release review so it'll be ready to launch first thing Monday.

Co-authored-by: Avinash Kunnath <[email protected]>
@fivetran-savage fivetran-savage added the docs:ready Triggers the docs generator workflow. label Oct 31, 2025
@fivetran-savage fivetran-savage merged commit 5f14721 into main Nov 3, 2025
9 checks passed
@fivetran-savage fivetran-savage deleted the feature/add_xero__calendar_start_date_var branch November 3, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow. type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants