-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[adminutils] membersteal #47
base: V3
Are you sure you want to change the base?
Conversation
Co-authored-by: Fixator10 <[email protected]>
Co-authored-by: Fixator10 <[email protected]>
Co-authored-by: Fixator10 <[email protected]>
Co-authored-by: Fixator10 <[email protected]>
Co-authored-by: Fixator10 <[email protected]>
Co-authored-by: Fixator10 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About that 'name' arg... What about implementing argparse for that?
Example: https://github.com/fixator10/Fixator10-Cogs/blob/V3.leveler_abc/leveler/commands/top.py
I don't know much about argparse and am not motivated to look into it right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps then we can add an special name _
to use original emoji's name?
like [p]emoji import _ 158155109289003029
will import emoji from 158155109289003029 with its original name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong button
Co-authored-by: Fixator10 <[email protected]>
Co-authored-by: Fixator10 <[email protected]>
Co-authored-by: Fixator10 <[email protected]>
This pull request introduces 1 alert when merging fe2b411 into 27ee04a - view on LGTM.com new alerts:
|
@@ -189,45 +189,79 @@ async def emoji_add(self, ctx, name: str, url: str, *roles: discord.Role): | |||
except discord.HTTPException as e: | |||
await ctx.send(chat.error(_("An error occured on adding an emoji: {}").format(e))) | |||
else: | |||
msg = _("{em} created with the name `{em.name}`".format(em=em)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msg = _("{em} created with the name `{em.name}`".format(em=em)) | |
msg = _("{em} created with the name `{em.name}`".format(em=e)) |
NameError: name 'em' is not defined
@@ -253,7 +292,7 @@ async def emoji_rename(self, ctx, emoji: discord.Emoji, name: str, *roles: disco | |||
await ctx.send_help() | |||
return | |||
try: | |||
await emoji.edit( | |||
em = await emoji.edit( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like emoji.edit
doesnt return anything, you need to re-get emoji, e.g. via em = bot.get_emoji(emoji.id)
https://discordpy.readthedocs.io/en/stable/api.html#discord.Emoji.edit
This pull request introduces 1 alert when merging f0eeb16 into 1a28ef0 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 88bcd45 into fd6c8e3 - view on LGTM.com new alerts:
|
Works similar to the message steal command, but allows you to steal an emoji from a member's status.