Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bboxes clipping #1401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove bboxes clipping #1401

wants to merge 1 commit into from

Conversation

rafis
Copy link

@rafis rafis commented Jun 27, 2020

fixes #882

@hgaiser
Copy link
Contributor

hgaiser commented Jun 29, 2020

How does this fix #882 ? The error comes from loading the annotations, but you removed the clipping from the output of the network?

@rafis
Copy link
Author

rafis commented Jul 3, 2020

Yea, it is not optimal solution. Some annotation tools does not support annotating bboxes outside of image shape. But I have tested this code and it works. Model successfully predicts those bboxes as like object being occluded by another object.

@hgaiser
Copy link
Contributor

hgaiser commented Jul 6, 2020

Ah I see now that you also removed the check from the generator. I'm not a big fan of this change. In my opinion the annotations should be inside the image and so should the predictions.

@hsahin hsahin changed the base branch from master to main June 17, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BBOX issues
2 participants