Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revised IP&URI template #1344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: revised IP&URI template #1344

wants to merge 1 commit into from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Feb 6, 2025 •
edited
Loading

  • fixed order of keys ('interesting' URIs -> URIs -> IPv4 -> IPv6)
  • sorted results
  • don't display 'interesting' URIs twice (also in URIs)

@jstucke
feat: revised IP&URI template
c775f7e 
* fixed order of keys ('interesting' URIs -> URIs -> IPv4 -> IPv6)

* sorted results

* don't display 'interesting' URIs twice
@jstucke jstucke requested a review from dorpvom February 6, 2025 16:41
@jstucke jstucke self-assigned this Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (b977028) to head (c775f7e).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   92.53%   91.78%   -0.75%     
==========================================
  Files         381      376       -5     
  Lines       24395    21099    -3296     
==========================================
- Hits        22574    19366    -3208     
+ Misses       1821     1733      -88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorpvom dorpvom Awaiting requested review from dorpvom

At least 1 approving review is required to merge this pull request.

Assignees

@jstucke jstucke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstucke @codecov-commenter