Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up kafka output tests #704

Merged
merged 1 commit into from
Nov 12, 2024
Merged

speed up kafka output tests #704

merged 1 commit into from
Nov 12, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Nov 12, 2024

you can check with:

pytest ./tests/unit/connector/test_confluent_kafka_output.py -vv --durations=10 --durations-min=1.0

main:
image

this branch:
image

@ekneg54 ekneg54 added the refactoring only refactoring, no change in behavior label Nov 12, 2024
@ekneg54 ekneg54 requested a review from dtrai2 November 12, 2024 08:25
@ekneg54 ekneg54 self-assigned this Nov 12, 2024
dtrai2
dtrai2 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@dtrai2 dtrai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple, but effective 😄

@ekneg54 ekneg54 merged commit ed4e659 into main Nov 12, 2024
13 checks passed
@ekneg54 ekneg54 deleted the dev-speedup-kafka-output-tests branch November 12, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrai2 dtrai2 dtrai2 approved these changes

Assignees

@ekneg54 ekneg54

Labels
refactoring only refactoring, no change in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekneg54 @dtrai2