[CICD] replace souce install with whl install#1121
Open
Darryl233 wants to merge 10 commits intoflagos-ai:mainfrom
Open
[CICD] replace souce install with whl install#1121Darryl233 wants to merge 10 commits intoflagos-ai:mainfrom
Darryl233 wants to merge 10 commits intoflagos-ai:mainfrom
Conversation
tengqm
reviewed
Feb 24, 2026
| else \ | ||
| echo "[ENV] Found uv venv at ${FLAGSCALE_HOME}/venv"; \ | ||
| fi; \ | ||
| elif [ "$PKG_MGR" = "conda" ]; then \ |
Contributor
There was a problem hiding this comment.
What's the point to have conda or miniconda inside a container?
For miniconda, the base installation is approximately 250 MB to 900 MB, while for venv, the footprint is typically 5-10 MB.
Are we planning to install multiple Python versions in the same container image or something?
tengqm
reviewed
Feb 24, 2026
| # Training-specific dependencies | ||
|
|
||
| -r ./base.txt | ||
| megatron_core @ https://resource.flagos.net/repository/flagos-pypi-hosted/packages/megatron-core/0.16.0rc0/megatron_core-0.16.0rc0-cp312-cp312-linux_x86_64.whl |
Contributor
There was a problem hiding this comment.
Where does this megatron_core come from?
The official release or megatron core is 0.15.3.
tengqm
reviewed
Feb 24, 2026
| ARG PYTORCH_INDEX | ||
| ARG PKG_MGR | ||
| ARG FLAGSCALE_HOME=/opt/flagscale | ||
| ARG PYTHON_VERSION=3.12 |
Contributor
There was a problem hiding this comment.
This is actually not configurable, because the packages we are installing later on are all about python3.12. Right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
CICD
PR Types
Improvements
PR Description