[TLE-Raw] implement vassert and add unit test #325
Merged
+178
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgjzfzzf
previously approved these changes
Jan 28, 2026
sgjzfzzf
requested changes
Jan 29, 2026
Collaborator
sgjzfzzf
left a comment
sgjzfzzf
left a comment
There was a problem hiding this comment.
Nice done! Btw could u please apply the newly added operation to topk.py to check the bdimx to be 1024 during runtime? That would be very helpful.
sgjzfzzf
approved these changes
Feb 1, 2026
zhzhcookie
changed the title
sunnycase
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the vassert function for the TLE Raw DSL.
Changes:
Implemented vassert in utils.py by targeting the correct __assertfail symbol, enabling native CUDA device-side assertions.
Added a new test case python/tutorials/tle/raw/05-test-assert.py to verify that assertions correctly terminate the kernel and report errors.