Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add testScenario() test method #2147

Merged
merged 109 commits into from
Nov 6, 2022
Merged

test: Add testScenario() test method #2147

merged 109 commits into from
Nov 6, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Nov 5, 2022

Description

Add testScenario() method for jenny, allowing to test different dialogues more easily. This is the same system as used by YarnSpinner, so that we can verify that language features are working the same way.

Some of the testplans from YarnSpinner were ported, though many of them are marked as skip=true. This gives us an opportunity to try TDD.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

@spydon spydon merged commit f6432c6 into main Nov 6, 2022
@spydon spydon deleted the ps.yarn-integration-tests branch November 6, 2022 20:40
@st-pasha st-pasha added the jenny Issues/PRs related to the Jenny package label Nov 24, 2022
@st-pasha st-pasha changed the title test(jenny): Add testScenario() test method test: Add testScenario() test method Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenny Issues/PRs related to the Jenny package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants