[MSN-2665] Set env var default to None #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iasmini
force-pushed
the
hotfix/msn-2665-ig-set-env-var-default-to-none
branch
from
7c18f08
to
e8f0c4c
Compare
iasmini
force-pushed
the
hotfix/msn-2665-ig-set-env-var-default-to-none
branch
from
e8f0c4c
to
9baaad2
Compare
added 2 commits
June 27, 2024 11:47
In GCP documentation (https://cloud.google.com/tasks/docs/quotas) the maximum schedule time for a task is 30 days from current date and time.
iasmini
force-pushed
the
hotfix/msn-2665-ig-set-env-var-default-to-none
branch
from
9baaad2
to
4597996
Compare
|
Code Climate has analyzed commit 4597996 and detected 0 issues on this pull request. View more on Code Climate. |
lucasgomide
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our applications use this library, but they are scheduling tasks with a deadline longer than the token expiration. Therefore, we cannot set a default value yet.
Issues
https://nilosaude.atlassian.net/browse/MSN-2665
Solution
Set maximum delay time default to None to be able to bypass this validation.