[MSN-2689] fix: cast env var values according to its type #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DWalterJansen
approved these changes
Jul 1, 2024
iasmini
force-pushed
the
hotfix/msn-2689-ig-cast-type-env-var-values
branch
from
22ab541
to
1ba8973
Compare
joaodaher
requested changes
Jul 1, 2024
iasmini
force-pushed
the
hotfix/msn-2689-ig-cast-type-env-var-values
branch
from
1ba8973
to
efbad60
Compare
elvisgs
reviewed
Jul 1, 2024
iasmini
force-pushed
the
hotfix/msn-2689-ig-cast-type-env-var-values
branch
from
efbad60
to
64e498d
Compare
|
Code Climate has analyzed commit 64e498d and detected 0 issues on this pull request. View more on Code Climate. |
joaodaher
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The value of the environment variable was being retrieved as a string, even if it was set to None. This led to the following error when attempting to compare an integer (delay_in_seconds) with a string (max_eta_task):
Issues
https://nilosaude.atlassian.net/browse/MSN-2689
Solution
To resolve this issue, we cast the environment variable to the appropriate type using specific methods according to its type. This ensures that the environment variable is correctly interpreted as an integer, list, or other expected types, preventing type mismatches during comparisons.