[shell-operator] feat/new operator event handling mechanism #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 13, 2025 18:27
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
…-operator-event-handling-mechanism
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
ldmonster
changed the title
juev
reviewed
Mar 18, 2025
| } | ||
|
|
||
| infos := hc.ScheduleController.HandleEvent(crontab) | ||
| if createTasksFn == nil { |
There was a problem hiding this comment.
And why do we check the input parameters only after we have called HandleEvent? If the functions have not been transferred, we do not use the result that we received earlier.
There was a problem hiding this comment.
looks like untouched code. this is not my logic.
previously, we have no returned values, just append to slice in closure.
now we have more clear structure with returning tasks values, if we handle it.
There was a problem hiding this comment.
I just pointed out what the eye caught on, the correction seems to be small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replace functional pattern with return values
What this PR does / why we need it
Special notes for your reviewer