Implement webhook publisher #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.25 also required bump of mock package
There was a problem hiding this comment.
Pull Request Overview
This PR implements a webhook publisher feature for the alerting system, allowing alerts to be sent to HTTP endpoints with configurable options. The implementation includes comprehensive deduplication, multiple HTTP method support, and proper error handling.
- Adds webhook configuration with URL, HTTP method, and optional JSON body sending
- Implements webhook publisher with message fingerprint-based deduplication
- Updates Go toolchain to 1.25 and switches from
mockgentogo tool mockgen
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| types/types.go | Adds AlertmanagerWebhook struct for webhook payload format |
| publisher/webhook.go | Core webhook publisher implementation with HTTP client abstraction |
| publisher/webhook_test.go | Comprehensive test suite covering various webhook scenarios |
| config/webhook.go | Webhook configuration structure with enabled check |
| config/config.go | Integrates webhook config into main configuration |
| processor/processor.go | Initializes webhook publisher with URL-based namespacing |
| cmd/lambda.go | Adds CLI flags and environment variable handling for webhook config |
| go.mod | Updates Go version to 1.25 and mock dependency |
| publisher/slack.go | Updates mockgen command to use go tool |
| publisher/pagerduty.go | Updates mockgen command to use go tool |
| publisher/publisher.go | Adds webhook expiry timeout constant |
| mock/publisher/webhook.go | Generated mock for HTTP client interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Add webhook configuration with URL, HTTP method, and send body options - Implement webhook publisher with deduplication using message fingerprints - Support for different HTTP methods and optional JSON body sending - Update processor to initialize webhook publisher when configured
ilyaluk
force-pushed
the
ilya/webhook-publisher
branch
from
18fb155 to
bc7f754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is partially Claude code-generated with manual review.