fix: jovian hardfork tests & fixes #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyalprout
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
Collaborator
We do check builder tx size and deduct it from total da size, have you accounted for this? |
danyalprout
force-pushed
the
fix-jovian
branch
from
0d3b68a to
eb0e675
Compare
avalonche
approved these changes
Nov 18, 2025
| } | ||
| // Save some space in the block_da_limit for builder tx | ||
| let builder_tx_da_size = builder_txs.iter().fold(0, |acc, tx| acc + tx.da_size); | ||
| info.cumulative_da_bytes_used += builder_tx_da_size; |
Collaborator
There was a problem hiding this comment.
this should be in here as the builder tx isn't necessarily committed yet
| // We subtract gas limit and da limit for builder transaction from the whole limit | ||
| let builder_tx_gas = builder_txs.iter().fold(0, |acc, tx| acc + tx.gas_used); | ||
| let builder_tx_da_size: u64 = builder_txs.iter().fold(0, |acc, tx| acc + tx.da_size); | ||
| info.cumulative_da_bytes_used += builder_tx_da_size; |
Collaborator
There was a problem hiding this comment.
this should be in here as the builder tx isn't necessarily committed yet
|
|
||
| let builder_tx_gas = builder_txs.iter().fold(0, |acc, tx| acc + tx.gas_used); | ||
| let builder_tx_da_size: u64 = builder_txs.iter().fold(0, |acc, tx| acc + tx.da_size); | ||
| info.cumulative_da_bytes_used += builder_tx_da_size; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
Needed for the hardfork.
✅ I have completed the following steps:
make lintmake test