fix: Separate flashblocks payloads handling and full built payloads in handler #354
+48
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieniven
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR separates out original fixes from PR #334. The original handler handles both flashblock payloads vs full built payloads with the same transmitter. This PR separates the handling logic on the 2 different triggers:
Note that since the subsequent PR #334 will be based on this fixes, there is no optimization done here and it maintains the same logic - full built payloads are sent after every flashblock execution. The subsequent SR optimization PR will only send the full built payloads (with SR calculated) on async payload resolution.