feat: add ordering by destination #65
Open
+107
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahimahmedx
requested review from
SozinM,
julio4 and
karim-agha
as code owners
fahimahmedx
changed the title
karim-agha
reviewed
Nov 12, 2025
|
|
||
| impl<P: Platform> OrderScore<P> for DestinationAndPriorityFeeScore<P> { | ||
| type Error = Infallible; | ||
| type Score = (u8, u128); |
Collaborator
There was a problem hiding this comment.
maybe instead of (u8, u128) we could simply have (bool, u128)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
OrderByDestinationAndPriorityFee, and ordering that prioritizes transactions going to a provided destination, followed by transactions that aren't going to the given destination. Inside each of these groups, transactions are ordered by priority fee.To implement this, we also had to modify
OrderByto store aOrderScorefield, which would allowDestinationAndPriorityFeeScore'sscore()being able to access itsdestination_addressfield.This enables top-of-block oracle updates for updates sent to the Global Storage smart contract.