Skip to content

fix version report: replace git dirty with ci platform due to bug in crate #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

sukoneck
Copy link
Contributor

@sukoneck sukoneck commented Nov 12, 2024

  • removes the warpcache. it's not doing anything right now and upstream needs updating
  • replaces the report of dirty from the version flag with build_platform because the built crate has a bug with dirty always reporting true

output now looks like this:

commit:         8bbfeb0
branch:         refs/heads/dirty-builds
build_platform: "GitHub Actions"
build_time:     Tue, 12 Nov 2024 22:07:06 +0000
features:       []
profile:        release
rustc:          rustc 1.82.0 (f6e511eec 2024-10-15)

@sukoneck sukoneck marked this pull request as ready for review November 12, 2024 22:28
@sukoneck sukoneck merged commit 47710ab into main Nov 13, 2024
1 check passed
@sukoneck sukoneck deleted the dirty-builds branch November 13, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants