chore: update ci pipeline and poetry version #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce dependencies' caching, python black testing and pytest in ci pipeline. Set the ubuntu agent to an explicit version. - Bump poetry version to 1.8.2, and bump all dev dependencies to their latest. Update flask to use <3.0.0 version. Following this version, the Markup module is not include in Flask anymore. - Run `black -l 80` on project - Update __version__ in __init__.py to "0.4.1" to make the test successful. (I don't see the functionality of this test. I will consider removing it in the next PR).
marcuxyz
reviewed
Apr 24, 2024
.github/workflows/ci.yaml
Outdated
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| - name: Install dependencies | ||
| run: poetry install |
There was a problem hiding this comment.
You can put this command in makefile and run only
E.g;
Make install
.github/workflows/ci.yaml
Outdated
|
|
||
| - name: Code Quality | ||
| run: | | ||
| pip install black | ||
| black -l 80 --check | ||
| poetry run black -l 80 --check . |
- Update Makefile to include all CI steps. Introduce `black` and `quality` tasks. The latter runs `black` and `pep8` tasks. - Update ci.yaml to include make tasks include of raw commands - Fix `black` related findings (i.e. mainly F401 ones). The F401 findings were related with typing module, so instructed `black` to ignore those.
|
Hey @marcuxyz , |
marcuxyz
reviewed
May 4, 2024
|
|
||
| test: pep8 | ||
| py.test --cov=flask_googlemaps -l --tb=short --maxfail=1 tests/ |
There was a problem hiding this comment.
was necessary to remove the -l --tb=short --maxfail=1 tests/ flags?
marcuxyz
approved these changes
May 4, 2024
|
@rochacbruno please review the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black -l 80on project