download_sysext: fix passing XML data with --input-xml #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --input-xml is on and --payload-url is off to pass XML data offline, we need to set payload_url to None and continue running the DownloadVerify builder instead of returning there. It is necessary to fix regressions of #87. Signed-off-by: Dongsu Park <[email protected]>
Since both `#[xml(child = "packages")]` and `#[xml(child = "actions"])` are not able to handle correct hierarchies of manifest (as parent) and packages and actions (as children), we need to define a separate structs for Packages that includes `Vec<Package>`, as well as `Actions` that includes `Vec<Action>`. Signed-off-by: Dongsu Park <[email protected]>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 24, 2025
Pulls in flatcar/ue-rs#93. Signed-off-by: Dongsu Park <[email protected]>
2 tasks
krnowak
approved these changes
Oct 24, 2025
james-parky
suggested changes
Oct 24, 2025
Contributor
james-parky
left a comment
james-parky
left a comment
There was a problem hiding this comment.
Some changes regarding module naming in omaha, otherwise ok.
dongsupark
force-pushed
the
dongsu/fix-input-xml
branch
from
cf70b08 to
2f9ccb2
Compare
james-parky
reviewed
Oct 28, 2025
Since we need to support decoding of both hex and base64 formats, bring back base64 decoding functionality. Note, while hash_sha256 of Package has hex format, sha256 of Action has base64 format. That is the reason why we need to keep both mod sha256_from_hex_str and mod sha256_from_base64_str. Signed-off-by: Dongsu Park <[email protected]>
dongsupark
force-pushed
the
dongsu/fix-input-xml
branch
from
2f9ccb2 to
7b95cee
Compare
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 29, 2025
Pulls in flatcar/ue-rs#93. Signed-off-by: Dongsu Park <[email protected]>
Member
Author
|
Jenkins CI through flatcar/scripts#3425 passed. |
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 31, 2025
When --input-xml is on and --payload-url is off to pass XML data offline, we need to set payload_url to None and continue running the DownloadVerify builder instead of returning there. Pulls in flatcar/ue-rs#93. Signed-off-by: Dongsu Park <[email protected]>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 31, 2025
When --input-xml is on and --payload-url is off to pass XML data offline, we need to set payload_url to None and continue running the DownloadVerify builder instead of returning there. Pulls in flatcar/ue-rs#93. Signed-off-by: Dongsu Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --input-xml is on and --payload-url is off to pass XML data offline, we need to set payload_url to None and continue running the DownloadVerify builder instead of returning there.
It is necessary to fix regressions of #87.
Maybe fixes #92.
Testing done
local test passed.
CI http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/6861/cldsv/ passed.