finish_args: Make standalone fallback-x11 an error

flathub-infra · Sep 26, 2023 · b83a095 · b83a095
1 parent d6adaba
commit b83a095
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/flatpak_builder_lint/checks/finish_args.py b/flatpak_builder_lint/checks/finish_args.py
@@ -17,6 +17,12 @@ def _validate(self, appid: Optional[str], finish_args: dict[str, Set[str]]) -> N
             if "ipc" not in finish_args["share"]:
                 self.warnings.add("finish-args-x11-without-ipc")
 
+        if (
+            "fallback-x11" in finish_args["socket"]
+            and "wayland" not in finish_args["socket"]
+        ):
+            self.errors.add("finish-args-fallback-x11-without-wayland")
+
         for xdg_dir in ["xdg-data", "xdg-config", "xdg-cache"]:
             if xdg_dir in finish_args["filesystem"]:
                 self.errors.add(f"finish-args-arbitrary-{xdg_dir}-access")