Better check for xdg-dir access #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfiguiere
force-pushed
the
xdg-dir-checks
branch
from
e677ed5
to
55eec24
Compare
hfiguiere
changed the title
|
Possibly close #91 |
|
this never got merged but now it conflicts... |
hfiguiere
force-pushed
the
xdg-dir-checks
branch
from
55eec24
to
e64f225
Compare
|
I have rebased it and the tests pass (locally) |
|
@barthalion can I merge this? |
- It would before allow `xdg-config:create`
hfiguiere
force-pushed
the
xdg-dir-checks
branch
from
e64f225
to
bdc5eee
Compare
|
great so now I need to fix the tests :-( |
|
Test have been broken before that. YOLO |
|
See #204 for the test failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xdg-config:createClose #91