Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No option for Last.fm Login after v2 upgrade #5

Open
ProjectSynchro opened this issue Aug 29, 2024 · 2 comments · May be fixed by #6
Open

No option for Last.fm Login after v2 upgrade #5

ProjectSynchro opened this issue Aug 29, 2024 · 2 comments · May be fixed by #6

Comments

@ProjectSynchro
Copy link
Contributor

ProjectSynchro commented Aug 29, 2024 •
edited
Loading

Originally posted here: ytmdesktop/ytmdesktop#1427 (comment)

It looks like we can either:

  1. Use basic credential storage (which uses plaintext somewhere in the sandbox)
  2. Allow access to the libsecret or kwallet dbus sockets

There's potentially also the option to wait for upstream to implement the secret portal: https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.impl.portal.Secret.html#secret

But that would be up to them if they pick to go that way.
ProjectSynchro added a commit to ProjectSynchro/app.ytmdesktop.ytmdesktop that referenced this issue Aug 29, 2024
@ProjectSynchro
Fix: Allow access to GNOME secrets and KWallet to fix No option for L…
e1072da 
…ast.fm Login after v2 upgrade flathub#5
@ProjectSynchro ProjectSynchro linked a pull request Aug 29, 2024 that will close this issue
Open
@ProjectSynchro
Copy link
Contributor Author

ProjectSynchro commented Aug 30, 2024 •
edited
Loading

I attempted to use the libsecret backend for portals support, but it seems broken upstream.

I think we will be forced to use basic secret storage, which works for the basic login feature, but doesn't work for lastfm integration.

@azizLIGHT
Copy link

In flatseal on KDE, I got lastfm integration working without the safeStorage complaint. Instructions from here helped me a lot.

I put org.freedesktop.secrets and org.kde.kwalletd5 into Flatseal -> ytmdesktop -> Session Bus -> Talks and then had to allow always to kdewallet by ytmdesktop. The command line equivalent would be flatpak override --user --talk-name=org.kde.kwalletd5 --talk-name=org.freedesktop.secrets app.ytmdesktop.ytmdesktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Electron Quirks ProjectSynchro/app.ytmdesktop.ytmdesktop
2 participants
@ProjectSynchro @azizLIGHT