-
Notifications
You must be signed in to change notification settings - Fork 2
Fix Electron Quirks #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Started test build 143310 |
Build 143310 successful
|
We can use desktop-file-edit to change the file for our needs.
e1072da
to
48011a5
Compare
Started test build 143319 |
Build 143319 successful
|
…d to avoid bugs. This unfortunately doesn't fix the issue seen in the lastfm integration.
Started test build 143335 |
Build 143335 successful
|
It seems like there is a bug with how decryption of secrets works between Flatpak and Electron. This essentially means that when using the Secrets portal, you can store a secret but not decrypt that secret without (potentially) some changes upstream as to how secrets are accessed. See for context: The second issue (#5) is due to an issue with Electron again. (go figure) Using the "basic" backend doesn't return isEncryptionAvailable as true for some reason.. So, this PR explicitly sets the password store to "basic" so the backend being used to store secrets (for decrypting login cookies and api keys) is consistent everywhere, a fix for the lastfm integration will have to come from an update upstream. The XDG_CURRENT_DESKTOP environment variable is set to "unity" due to potential issues with.. you guessed it. Electron: electron/electron#39789. Setting this variable bypasses this issue. This change doesn't cause any issues with the current Flatpak being updated, as we are already using the "basic" secrets backend due to process of elimination but setting it explicitly prevents issues in the future. It isn't as secure as using a proper secrets backend is, but it is the only backend that works. |
Added a workaround for ANOTHER Electron bug: electron/electron#40461 This should solve crashes when the "Show notification on song change" option is enabled. |
Started test build 143352 |
Build 143352 successful
|
Fixes #5
This allows access to the Gnome secrets, libsecret and kwallet sockets which should allow electron safeStorage to function correctly.