runtime: Update to 48

[A6GibKm]

Marked as WIP as libgphotos-lib32 is not compiling.

[flathubbot]

Started test build 191899

[A6GibKm]

@bbhtt libgphotos-lib32 with the 47 runtime did build, did something change in 24.08?

[A6GibKm]

@bbhtt libgphotos-lib32 with the 47 runtime did build, did something change in 24.08?

I also had to add libusb for some reason.

[flathubbot]

Build 191899 failed

[flathubbot]

Started test build 191903

[flathubbot]

Build 191903 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/175189/net.lutris.Lutris.flatpakref

[bbhtt]

What's the error?

[A6GibKm]

What's the error?

libtool: link: ( cd ".libs" && rm -f "usbscsi.la" && ln -s "../usbscsi.la" "usbscsi.la" )
libtool: link: echo "{ global:" > .libs/serial.ver
libtool: link:  cat ./iolib.sym | /usr/bin/sed -e "s/\(.*\)/\1;/" >> .libs/serial.ver
libtool: link:  echo "local: *; };" >> .libs/serial.ver
libtool: link:  i686-unknown-linux-gnu-gcc -shared  -fPIC -DPIC  serial/.libs/la-unix.o   -Wl,-rpath -Wl,/run/build/libgphoto2-32bit/libgphoto2_port/libgphoto2_port/.libs -Wl,-rpath -Wl,/app/lib32 -L/app/lib -L/app/lib32 ./libgphoto2_port/.libs/libgphoto2_port.so -lltdl -lpthread  -O2 -g -fstack-protector-strong -grecord-gcc-switches -mno-omit-leaf-frame-pointer -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed   -Wl,-soname -Wl,serial.so -Wl,-version-script -Wl,.libs/serial.ver -o .libs/serial.so
libtool: link: ( cd ".libs" && rm -f "serial.la" && ln -s "../serial.la" "serial.la" )
mv -f libusb1/.deps/usb1_la-libusb1.Tpo libusb1/.deps/usb1_la-libusb1.Plo
/bin/sh ./libtool  --tag=CC   --mode=link i686-unknown-linux-gnu-gcc  -O2 -pipe -g -Wp,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -Wall -Wmissing-declarations -Wmissing-prototypes -module -no-undefined -avoid-version -export-dynamic -export-symbols ./iolib.sym -rpath '/app/lib32/libgphoto2_port/0.12.2' -L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed  -L/app/lib32 -o usb1.la  libusb1/usb1_la-libusb1.lo ./libgphoto2_port/libgphoto2_port.la -L/app/lib32 -lusb-1.0  -lpthread 
libtool: link: echo "{ global:" > .libs/usb1.ver
libtool: link:  cat ./iolib.sym | /usr/bin/sed -e "s/\(.*\)/\1;/" >> .libs/usb1.ver
libtool: link:  echo "local: *; };" >> .libs/usb1.ver
libtool: link:  i686-unknown-linux-gnu-gcc -shared  -fPIC -DPIC  libusb1/.libs/usb1_la-libusb1.o   -Wl,-rpath -Wl,/run/build/libgphoto2-32bit/libgphoto2_port/libgphoto2_port/.libs -Wl,-rpath -Wl,/app/lib -Wl,-rpath -Wl,/app/lib32 -Wl,-rpath -Wl,/app/lib -L/app/lib -L/app/lib32 ./libgphoto2_port/.libs/libgphoto2_port.so -lltdl /app/lib/libusb-1.0.so -ludev -lpthread  -O2 -g -fstack-protector-strong -grecord-gcc-switches -mno-omit-leaf-frame-pointer -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed   -pthread -Wl,-soname -Wl,usb1.so -Wl,-version-script -Wl,.libs/usb1.ver -o .libs/usb1.so
/usr/lib/sdk/toolchain-i386/lib/x86_64-linux-gnu/gcc/i686-unknown-linux-gnu/14.2.0/../../../../../i686-unknown-linux-gnu/bin/ld: /app/lib/libusb-1.0.so: error adding symbols: file in wrong format
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:921: usb1.la] Error 1
make[4]: Leaving directory '/run/build/libgphoto2-32bit/libgphoto2_port'
make[3]: *** [Makefile:1228: all-recursive] Error 1
make[3]: Leaving directory '/run/build/libgphoto2-32bit/libgphoto2_port'
make[2]: *** [Makefile:726: all] Error 2
make[2]: Leaving directory '/run/build/libgphoto2-32bit/libgphoto2_port'
make[1]: *** [Makefile:770: all-recursive] Error 1
make[1]: Leaving directory '/run/build/libgphoto2-32bit'
make: *** [Makefile:594: all] Error 2
Error: module libgphoto2-32bit: Child process exited with code 2

[flathubbot]

Started test build 191964

[flathubbot]

Build 191964 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/175249/net.lutris.Lutris.flatpakref

[pizzadude]

Breaks Steam Deck input again.

[darkdragon-001]

Thanks for working on this!

As 46 is EOL, could we first update to 47 while we figure out the issues with 48?

[A6GibKm]

No, both 47 and 48 use the fdo 24.08 runtime which is where the issue starts. I have no idea what the issue is to be honest, the steam and bottles flatpak do not have this issue.

I think it is very likely the issue is somewhere in the flatpak manifest and not in the runtime itself or the app itself.

[RayJW]

Perhaps additional permission are required to solve this issue, kinda like Heroic Games Launcher approached it?

[A6GibKm]

I do not see any permission related to input in the PR. Do you have anything specific in mind?

[RayJW]

I do not see any permission related to input in the PR. Do you have anything specific in mind?

No, not necessarily. It's kind of a long shot, but the permissions are the only change I see to this PR that seems to have issues with Steam Input, which I'd assume might be what's breaking the Steam Deck controller. According to the comment in the PR, it seems that they copied the permissions (at least in some part) from the Steam Flatpak, which also doesn't have issues with the 24.04 runtime. Sadly, a lot of ifs and buts, but I can't really help more than that since I don't own a Steam Deck.

[A6GibKm]

The good thing is that all of the permissions in the linked PR can be tested in the build generated by this PR by adding those flags to the flatpak run incantation. I do not own a steam deck so I cannot test it.

[RayJW]

The good thing is that all of the permissions in the linked PR can be tested in the build generated by this PR by adding those flags to the flatpak run incantation. I do not own a steam deck so I cannot test it.

Maybe you can copy-paste the permissions and then @pizzadude can retest? Doing it via CLI might be cumbersome on the Deck. It would be an easy revert anyway.

[pizzadude]

The good thing is that all of the permissions in the linked PR can be tested in the build generated by this PR by adding those flags to the flatpak run incantation. I do not own a steam deck so I cannot test it.

Maybe you can copy-paste the permissions and then @pizzadude can retest? Doing it via CLI might be cumbersome on the Deck. It would be an easy revert anyway.

I tested the latest Heroic flatpak on the deck, and it has the same issue for older wine/proton versions (8.x and below), however, Proton 9.x and GE-Proton 9.x work fine. (didn't test 10.x yet). Maybe going forward, if we can't find a solution to this issue (why does Bottles work?), since Proton 9.x versions work, maybe we could ignore this issue and just tell people to use Proton 9.x and above. Though we would have to test if that's the case on Lutris also.

[mtomaschek]

I locally built the Flatpak from this branch, installed it on the deck, and tested various configurations. Proton 9 and above and Wine 10 seem to work fine. Wine GE 8 does not work in game mode.

Wine version	Desktop mode	Game mode
wine-ge-8-26 (Lutris default)	Works	No controller detected
System Wine 10 (from Flatpak)	Works	Works
Proton 9	Works	Works
Proton Experimental (10)	Works	Works
Proton GE 10-3	Works	Works

[pizzadude]

I locally built the Flatpak from this branch, installed it on the deck, and tested various configurations. Proton 9 and above and Wine 10 seem to work fine. Wine GE 8 does not work in game mode.

Wine version Desktop mode Game mode
wine-ge-8-26 (Lutris default) Works No controller detected
System Wine 10 (from Flatpak) Works Works
Proton 9 Works Works
Proton Experimental (10) Works Works
Proton GE 10-3 Works Works

Can you test if you have this issue also? Open-Wine-Components/umu-launcher#470

[user1-github]

I just randomly stumbled upon this PR and noticed that it adds libusb. I don't think this is necessary because org.winehq.Wine already has libusb in its manifest and Lutris utilizes it as a base app.

libusb is also going to be included in runtime 25.08.

[alatiera]

Could we merge this? the only regression is on a incredibly old version of proton, of which not even on steam os I had working controls for the deck.

[A6GibKm]

I am marking as not-a-draft, but someone should mention what exactly has regressed and whether this should be merged as is.

[flathubbot]

✅ Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/221774/net.lutris.Lutris.flatpakref

[Mershl]

the Heroic Launcher which faced the same limitations/issues has merged and released their 23.08->25.08 update today
flathub/com.heroicgameslauncher.hgl#247

I can't say whether they implemented workarounds or accepted the breakage with fairly old runners.

[0Qwel]

This fixes the file picker for me, and brings a more recent NVK version with significantly better performances.

It may just be due to my fancy exotic setup, but I would rather have "a controller bug on a runner you shouldn't use" than "a bug on the 'select executable' button and be forced to install the nvidia proprietary drivers"

I don't know if anyone is having the same issues, I just want to point out that the EOL Mesa and Gnome runtimes are likely to cause at least as much pain as the controller-on-old-runner situation

[renner0e]

bot, build

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

✅ Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/224132/net.lutris.Lutris.flatpakref

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

✅ Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/226495/net.lutris.Lutris.flatpakref

[scarylizard]

bot, build

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

❌ Test build failed.

Help

• bot, build - Restart the test build
• bot, ping admins - Contact Flathub admins

[A6GibKm]

bot, build

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

❌ Test build was cancelled.

Help

• bot, build - Restart the test build
• bot, ping admins - Contact Flathub admins

[flathubbot]

🚧 Started test build.

[flathubbot]

✅ Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/232373/net.lutris.Lutris.flatpakref

Built for x86_64 architecture.