Skip to content

Conversation

Mershl
Copy link

@Mershl Mershl commented Apr 26, 2025

xdg-config provides an generic approach that allows users and distros to use a config dir other than ~/.config

tested on Fedora 40/41/42

fixes #429

@flathubbot
Copy link
Contributor

🚧 Test build enqueued.

@flathubbot
Copy link
Contributor

🚧 Started test build.

@flathubbot
Copy link
Contributor

🚧 Test build failed.

@Mershl
Copy link
Author

Mershl commented Apr 26, 2025

The manifest validation throws an https://docs.flathub.org/docs/for-app-authors/linter#finish-args-unnecessary-xdg-config-subdir-mode-access, but that's exactly what we want here.

@victorsouzaleal
Copy link

The manifest validation throws an https://docs.flathub.org/docs/for-app-authors/linter#finish-args-unnecessary-xdg-config-subdir-mode-access, but that's exactly what we want here.

It's because the :ro in this case with xdg-config is really unnecessary, it works as expected with xdg-config/MangoHud, I didn't want to open another PR because you already reported the issue and opened a PR, try to fix it.

@Mershl
Copy link
Author

Mershl commented Jun 5, 2025

It's because the :ro in this case with xdg-config is really unnecessary

Omitting :ro will default to read AND write permission, which is best practice to avoid for these cases. But if this infact avoids the validation error then... I'll force push the PR in a sec.

@flathubbot
Copy link
Contributor

🚧 Test build enqueued.

@flathubbot
Copy link
Contributor

🚧 Started test build.

@flathubbot
Copy link
Contributor

🚧 Test build failed.

@Mershl
Copy link
Author

Mershl commented Jun 5, 2025

The manifest validation throws an https://docs.flathub.org/docs/for-app-authors/linter#finish-args-unnecessary-xdg-config-subdir-mode-access, but that's exactly what we want here.

It's because the :ro in this case with xdg-config is really unnecessary, it works as expected with xdg-config/MangoHud, I didn't want to open another PR because you already reported the issue and opened a PR, try to fix it.

xdg-config/MangoHud throws the same validation error, see log above. I'm reverting it back to :ro again.

xdg-config provides an generic approach that allows users and distros to use a config dir other than ~/.config

tested on Fedora 40/41/42

fixes flathub#429
@flathubbot
Copy link
Contributor

🚧 Test build enqueued.

@flathubbot
Copy link
Contributor

🚧 Started test build.

@flathubbot
Copy link
Contributor

🚧 Test build failed.

@RayJW
Copy link
Contributor

RayJW commented Aug 3, 2025

This won't build unless there is an exception added to https://github.com/flathub-infra/flatpak-builder-lint. A PR will probably be accepted pretty easily, seeing as the permission is already present, just differently and the need for it is justified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--filesystem=~/.config/MangoHud:ro not functional on Fedora

4 participants