Conversation
ffmpeg: Update ffmpeg-6.1.1.tar.xz to 7.1 libvips: Update vips-8.15.1.tar.xz to 8.16.0
Note that updating the generated sources is more complicated at the moment until flatpak-node-generator starts supporting Yarn version 2+. I had to use the code in pull request flatpak/flatpak-builder-tools#252 which adds support for Yarn version 2+. The exact commit that I used is: flatpak/flatpak-builder-tools@eb43ec2. A newer update of this pull request also removes the need to execute "$FLATPAK_BUILDER_BUILDDIR/flatpak-node/yarn2-setup.sh" before running "yarn install" so I removed that line from the build-commands. Commands that I used to update the generated sources are: wget https://raw.githubusercontent.com/mifi/lossless-cut/refs/tags/v3.64.0/yarn.lock pipx run "flatpak_node_generator @ git+https://github.com/flatpak/flatpak-builder-tools.git@refs/pull/252/head#subdirectory=node" yarn yarn.lock --output generated-sources.json rm yarn.lock
And ensure it is installed in $FLATPAK_DEST/bin directory. This follows: https://docs.flathub.org/docs/for-app-authors/linter/#toplevel-command-is-path.
|
Started test build 160652 |
|
Build 160652 failed |
Hmm... the failures are in the Excerpt from the build log: |
yeah, we need full offline builds. how have you built the generated-sources? |
How could we change the builds steps to do that?
I had to use the code in pull request flatpak/flatpak-builder-tools#252 which adds support for Yarn version 2+. The exact commit that I used is: flatpak/flatpak-builder-tools@eb43ec2. A newer update of flatpak/flatpak-builder-tools#252 also removes the need to execute Commands that I used to update the generated sources are: wget https://raw.githubusercontent.com/mifi/lossless-cut/refs/tags/v3.64.0/yarn.lock
pipx run "flatpak_node_generator @ git+https://github.com/flatpak/flatpak-builder-tools.git@refs/pull/252/head#subdirectory=node" yarn yarn.lock --output generated-sources.json
rm yarn.lock |
The whole Javascript ecosystem is, IMHO, not very well set up for this requirement and embraces an insecure YOLO culture of just downloading and running everything from the Internet, but I disgress. Your approach seems to be sane. But reading up now on the history I remember that I also had trouble making it work. So maybe you need to double and triple check the lock files you're using with the node generator. |
Yeah, I'm not a fan of the JS packaging ecosystem either. I've asked in the pull request flatpak/flatpak-builder-tools#252 (comment) if the author has any suggestions on which command to use to make the Yarn package fetching and installation work with the latest Yarn version (LosslessCut currently uses version 4.4.0).
I took a second look and compared the [tadej@toronto ~]$ pushd $(mktemp -d bla-XXXXX)
~/bla-HPzuw ~
[tadej@toronto bla-HPzuw]$ wget https://github.com/mifi/lossless-cut/archive/v3.64.0.tar.gz
v3.64.0.tar.gz 100% [===========================================================================================================>] 2.11M 4.47MB/s
[Files: 1 Bytes: 2.11M [1.64MB/s] Redirects: 1 Todo: 0 Errors: 0 ]
[tadej@toronto bla-HPzuw]$ tar -xf v3.64.0.tar.gz
[tadej@toronto bla-HPzuw]$ sha256sum lossless-cut-3.64.0/yarn.lock
def16157a78fec434c1ff09e157b25d8b42ed00b45192df8b51e0cb32ede39ab lossless-cut-3.64.0/yarn.lock
[tadej@toronto bla-HPzuw]$ wget https://raw.githubusercontent.com/mifi/lossless-cut/refs/tags/v3.64.0/yarn.lock
yarn.lock 100% [===========================================================================================================>] 131.79K 1.69MB/s
[Files: 1 Bytes: 131.79K [237.47KB/s] Redirects: 0 Todo: 0 Errors: 0 ]
[tadej@toronto bla-HPzuw]$ sha256sum yarn.lock
def16157a78fec434c1ff09e157b25d8b42ed00b45192df8b51e0cb32ede39ab yarn.lock
[tadej@toronto bla-HPzuw]$They are identical. |
|
hrm. |
No, I didn't do a full install beforehand. Now tried with a full install in the lossless-cut v3.64.0 checkout and it produces the same |
|
Sorry for the late reply. |
|
I tried to build it using @catsout 's build tools flatpak/flatpak-builder-tools#252 which successfully generated Similar case: flathub/social.whalebird.WhalebirdDesktop#23 Maybe it is possible to generate By the way, are there any drawbacks to using the pre-built linux release provided by the upstream repository? Could we skip the build steps and simply download and package |
|
@holubv, thanks for taking a deep dive into this and writing up what you've discovered!
@catsout, do you plan on updating the
Would this perhaps be a viable option?
@muelli, would it make sense to switch to the upstream pre-built binaries? |
I see that @catsout has created a new pull request: flatpak/flatpak-builder-tools#494 that adds support for Yarn Berry (i.e. Yarn version 2+) to flatpak-builder-tools. @catsout, do you have an example on how to use the new Yarn provider? |
5 participants
No description provided.