Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kde-cli-tools to get keditfiletype5 #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add kde-cli-tools to get keditfiletype5 #58

wants to merge 1 commit into from

Conversation

travier
Copy link
Member

@travier travier commented Nov 12, 2021

Fixes: #57

@flathubbot
Copy link
Contributor

Started test build 66854

@flathubbot
Copy link
Contributor

Build 66854 failed

@travier
Copy link
Member Author

travier commented Nov 12, 2021

This needs plasma-workspace at build time only.

@RokeJulianLockhart RokeJulianLockhart mentioned this pull request Nov 29, 2021
Closed
@Justinzobel
Copy link
Member

bot, build

@flathubbot
Copy link
Contributor

Queued test build for org.kde.dolphin.

@flathubbot
Copy link
Contributor

Started test build 51961

@flathubbot
Copy link
Contributor

Build 51961 failed

Justinzobel
Justinzobel reviewed Jul 10, 2023
View reviewed changes
org.kde.dolphin.json Outdated Show resolved Hide resolved
Justinzobel
Justinzobel reviewed Jul 10, 2023
View reviewed changes
org.kde.dolphin.json Outdated Show resolved Hide resolved
Justinzobel
Justinzobel reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@Justinzobel Justinzobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update kde-cli-tools to 5.27.6, this might resolve the issue.

@flathubbot
Copy link
Contributor

Started test build 52304

@flathubbot
Copy link
Contributor

Build 52304 failed

@Justinzobel
Copy link
Member

It needs plasma-workspace, so how do we get plasma-workspace in there at build-time only @travier?

@travier
Copy link
Member Author

travier commented Jul 10, 2023

We need to add a "plasma-workspace" module above this change in the manifest and figure out which pieces of it are need for the kde-cli-tools. We probably don't want to have the full plasma-workspace installation in the Dolphin Flatpak.

@Justinzobel
Copy link
Member

I might come back to this over the weekend to poke at it, see if I can't add it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justinzobel Justinzobel Justinzobel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to edit File Type Options for file/folder properties
3 participants
@travier @flathubbot @Justinzobel