Skip to content

Commit

Permalink
fixing review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
DiamonDinoia committed Jul 31, 2024
1 parent db80aad commit c225fb5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 207 deletions.
2 changes: 2 additions & 0 deletions src/cuda/common.cu
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,8 @@ void cufinufft_setup_binsize(int type, int ns, int dim, cufinufft_opts *opts) {
throw std::runtime_error(cudaGetErrorString(err));
}
// use 1/6 of the shared memory for the binsize
// From experiments on multiple GPUs this gives the best tradeoff.
// It is within 90% of the maximum performance for all GPUs tested.
shared_mem_per_block /= 6;
const int bin_size =
shared_mem_per_block / sizeof(cuda_complex<T>) - ((ns + 1) / 2) * 2;
Expand Down
Loading

0 comments on commit c225fb5

Please sign in to comment.