Remove dim and type from cufinufft_default_opts.
#337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now only requires a pointer to the options struct since we don't need the type or dimension anymore.
|
@blackwer No rush. Just figured you'd want to look through this when you get back. |
blackwer
approved these changes
Sep 7, 2023
| @@ -104,54 +103,11 @@ int cufinufft_default_opts(int type, int dim, cufinufft_opts *opts) | |||
|
|
|||
| opts->gpu_maxbatchsize = 0; // Heuristically set | |||
|
|
|||
| switch (dim) { | |||
There was a problem hiding this comment.
This does some sanity checking, which is now gone. This defers it to a later step, which is fine, but we should consider how to best deal with invalid inputs at some point.
There was a problem hiding this comment.
Right. I'll move it into makeplan at some point. Will make an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the interface in line with Finufft per #255. The
dimandtype(well, actually onlytype) were used to setgpu_method. Now this is set to0, an “auto” setting which results inmake_planchoosing the most appropriate method for the type. (We'll be able to incorporate precision later as well, see #321.)Resolves #255.