Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change finufft targets to provide proper install interface include dirs #449

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Wentzell
Copy link
Member

Change finufft targets to provide proper install interface include dirs

Copy link
Collaborator

@ahbarnett ahbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I still don't use cmake much, I don't understand what's changing here. Please can you explain a little? Thanks! Alex

@Wentzell
Copy link
Member Author

Wentzell commented Jun 3, 2024

This commit changes the include directory location for the library targets such as finufft and finufft_static depending on the context in which they are used. For the finufft build itself, i.e. before installing the library, the ${CMAKE_CURRENT_SOURCE_DIR}/include directory should be used. For other projects consuming an installed version of FINUFFT, the ${CMAKE_INSTALL_PREFIX}/include directory should be used.

@ahbarnett ahbarnett merged commit e4ad80e into flatironinstitute:master Jun 4, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants