added pre commit hook #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To check, this won't destroy all the git blame info for the source code, right? I don't use auto format - will it mess up my commenting in the source? |
There's a lot of discussion about this in the slack, but as is, this won't do anything to the existing code. It should only reformat changes automatically. Was hoping we could continue the discussion from the slack in today's meeting to talk about doing a reformat commit, though -- it's trivial to make git ignore the reformat commit for blames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a pre-commit-hook to format the code automatically at every commit. It uses the .clang-format provided by @blackwer in the git root.