Find all crates in git repositories, matching cargo's behavior #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `get_git_repo_packages` only finds dependencies that are in the dep or workspace member trees of their repo's root `Crate.toml` or `*/Cargo.toml`. This can cause a KeyError in `get_git_package_sources`.
zecakeh
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
I checked quickly Cargo's source code and it seems that it does recurse to find all Cargo.tomls, without a care about what the workspace says.
Workspace members are used for two things: if there is a workspace = true in one of the member definitions, it allows to fetch, and for cargo commands that can apply to a whole workspace.
This is a bit simplistic, for 2 things:
- It adds the parent workspace to all packages, even if they are not a member of it. It should be fine though, except maybe in possible very weird cases where there are several workspaces in a tree and the package is not a member of the workspace that is the closest ancestor. My take is that this can probably be overlooked.
- It doesn't recurse to get package dependencies, which should also be fine since
Cargo.lockshould list them all.
I tested this with the same Cargo.lock as #405, without any issue. I also successfully tested that this fixes #322 (because it doesn't recurse into the dependencies).
|
Thanks for the help reviewing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
get_git_repo_packagesonly finds git dependencies that are:Cargo.tomlor*/Cargo.toml)Otherwise,
get_git_package_sourcesthrows a KeyError.I found this with
eframe:Full Debug Log