Skip to content

Commit

Permalink
run: Don't pass --die-with-parent when we --run
Browse files Browse the repository at this point in the history
In this case we will exec rather than fork + exec, so we don't
want to use prctl, as that can cause the app to die if any
*thread* in the parent dies (rather then the whole process).

In particular, this caused issues for gnome-builder starting
a newly built flatpak:ed app.

Closes: #51
Approved by: alexlarsson
  • Loading branch information
alexlarsson authored and rh-atomic-bot committed Oct 27, 2017
1 parent 122ab65 commit f5693ab
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/builder-manifest.c
Original file line number Diff line number Diff line change
Expand Up @@ -3427,7 +3427,6 @@ builder_manifest_run (BuilderManifest *self,
args = g_ptr_array_new_with_free_func (g_free);
g_ptr_array_add (args, g_strdup ("flatpak"));
g_ptr_array_add (args, g_strdup ("build"));
g_ptr_array_add (args, g_strdup ("--die-with-parent"));
g_ptr_array_add (args, g_strdup ("--with-appdir"));

build_dir_path = g_file_get_path (builder_context_get_build_dir (context));
Expand Down

0 comments on commit f5693ab

Please sign in to comment.