Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button placement key #996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+46 −0
Open

Button placement key #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions data/org.freedesktop.impl.portal.Settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,29 @@
Unknown values should be treated as 0 (no preference).
</para></listitem>
</varlistentry>
<varlistentry>
<term>org.freedesktop.appearance button-placement (asas)</term>
<listitem><para>
Indicates the system's preferred arrangement of buttons on the titlebar.
In LTR locales, the first tuple is on the left (leading), and the second tuple is on the right (trailing).
In RTL locales, the first tuple is on the right (leading), and the second tuple is on the left (trailing).
Supported values are:
<simplelist>
<member>close: the close button</member>
<member>minimize: the minimize button</member>
<member>maximize: the maximize button</member>
</simplelist>
Unknown values must be ignored if the client does
not understand them. Duplicate buttons across the tuples and
string arrays are not allowed.
Comment on lines +47 to +60
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebassi @jadahl do you both have any thoughts on other paths this could take? anything nicer to expose over dbus? anything that's easier to put into code? it is Not Fun™ as-is.

Examples:
<simplelist>
<member>`(["close","minimize","maximize"][])` would result in the close, minimize, and maximize buttons being drawn on the leading side of the window, in that order; there will be no buttons on the trailing side of the window.</member>
<member>`([]["close"])` would result in the close button being drawn on the trailing side of the window; there will be no buttons on the leading side of the window.</member>
<member>`(["close"]["maximize"])` would result in the close button being drawn on the leading side of the window, and the maximize button being drawn on the trailing side of the window.</member>
</simplelist>
</para></listitem>
</varlistentry>
</variablelist>

Implementations can provide other keys; they are entirely
Expand Down
23 changes: 23 additions & 0 deletions data/org.freedesktop.portal.Settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,29 @@
Unknown values should be treated as 0 (no preference).
</para></listitem>
</varlistentry>
<varlistentry>
<term>org.freedesktop.appearance button-placement (asas)</term>
<listitem><para>
Indicates the system's preferred arrangement of buttons on the titlebar.
In LTR locales, the first tuple is on the left (leading), and the second tuple is on the right (trailing).
In RTL locales, the first tuple is on the right (leading), and the second tuple is on the left (trailing).
Supported values are:
<simplelist>
<member>close: the close button</member>
<member>minimize: the minimize button</member>
<member>maximize: the maximize button</member>
</simplelist>
Unknown values must be ignored if the client does
not understand them. Duplicate buttons across the tuples and
string arrays are not allowed.
Examples:
<simplelist>
<member>`(["close","minimize","maximize"][])` would result in the close, minimize, and maximize buttons being drawn on the leading side of the window, in that order; there will be no buttons on the trailing side of the window.</member>
<member>`([]["close"])` would result in the close button being drawn on the trailing side of the window; there will be no buttons on the leading side of the window.</member>
<member>`(["close"]["maximize"])` would result in the close button being drawn on the leading side of the window, and the maximize button being drawn on the trailing side of the window.</member>
</simplelist>
</para></listitem>
</varlistentry>
</variablelist>
orowith2os marked this conversation as resolved.
Show resolved Hide resolved

Implementations can provide other keys; they are entirely
Expand Down