-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API design] Add end user's IdP information to host vitals #26855
base: docs-v4.67.0
Are you sure you want to change the base?
Conversation
Related to: - #23236
@@ -3491,100 +3509,6 @@ Request (`filters` is specified and empty, to delete all hosts): | |||
|
|||
`Status: 200` | |||
|
|||
### Get human-device mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev note:
This endpoint should remain for backwards compatibility. We want to undocumented this as we'll introduce new endpoints that fit better in new IdP to host vitals experience.
|
||
--- | ||
|
||
### Update custom human-device mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev note:
This endpoint should remain for backwards compatibility. We want to undocumented this as we'll introduce new endpoints that fit better in new IdP to host vitals experience.
@@ -96,6 +96,7 @@ GitOps is an API-only and write-only role that can be used on CI/CD pipelines. | |||
| Edit [macOS setup experience]([https://fleetdm.com/docs/](https://fleetdm.com/guides/macos-setup-experience))\* | | | ✅ | ✅ | ✅ | | |||
| Add and edit identity provider for end user authentication, end user license agreement (EULA), and end user migration workflow\* | | | | ✅ | | | |||
| Add and edit Simple Certificate Enrollment Protocol (SCEP) server\* | | | | ✅ | ✅ | | |||
| Connect identity provider (IdP) to add end user informations to hosts\* | | | ✅ | ✅ | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Connect identity provider (IdP) to add end user informations to hosts\* | | | ✅ | ✅ | | | |
| Add end user information to hosts\* | | | ✅ | ✅ | | |
Do you think this is clear enough? If yes, I think let's move it in the table next to the other hosts rows. Maybe right below "Add/remove manual labels to/from hosts": https://github.com/fleetdm/fleet/pull/26855/files#diff-61a0f8c7cd442fab953eefa601995b52cce1b360efacec358968ef6f2c6a195cR44
@@ -1116,6 +1116,16 @@ | |||
jamfProtectHasFeature: no | |||
waysToUse: | |||
- description: Automatically set admin access to Fleet based on your IDP | |||
- industryName: Map IdP users to devices (SCIM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left some feedback re permissions and pricing.
Also, I updated this PR to "Ready for review" to @rachaelshaw knows the API changes are ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API lgtm!
Related to: