Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API design] Add end user's IdP information to host vitals #26855

Open
wants to merge 10 commits into
base: docs-v4.67.0
Choose a base branch
from

Conversation

marko-lisica
Copy link
Member

@@ -3491,100 +3509,6 @@ Request (`filters` is specified and empty, to delete all hosts):

`Status: 200`

### Get human-device mapping
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note:

This endpoint should remain for backwards compatibility. We want to undocumented this as we'll introduce new endpoints that fit better in new IdP to host vitals experience.


---

### Update custom human-device mapping
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note:

This endpoint should remain for backwards compatibility. We want to undocumented this as we'll introduce new endpoints that fit better in new IdP to host vitals experience.

@@ -96,6 +96,7 @@ GitOps is an API-only and write-only role that can be used on CI/CD pipelines.
| Edit [macOS setup experience]([https://fleetdm.com/docs/](https://fleetdm.com/guides/macos-setup-experience))\* | | | ✅ | ✅ | ✅ |
| Add and edit identity provider for end user authentication, end user license agreement (EULA), and end user migration workflow\* | | | | ✅ | |
| Add and edit Simple Certificate Enrollment Protocol (SCEP) server\* | | | | ✅ | ✅ |
| Connect identity provider (IdP) to add end user informations to hosts\* | | | ✅ | ✅ | |
Copy link
Member

@noahtalerman noahtalerman Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Connect identity provider (IdP) to add end user informations to hosts\* | | ||| |
| Add end user information to hosts\* | | ||| |

Do you think this is clear enough? If yes, I think let's move it in the table next to the other hosts rows. Maybe right below "Add/remove manual labels to/from hosts": https://github.com/fleetdm/fleet/pull/26855/files#diff-61a0f8c7cd442fab953eefa601995b52cce1b360efacec358968ef6f2c6a195cR44

@@ -1116,6 +1116,16 @@
jamfProtectHasFeature: no
waysToUse:
- description: Automatically set admin access to Fleet based on your IDP
- industryName: Map IdP users to devices (SCIM)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think let's try putting this new row below the existing "Human-endpoint mapping":

Screenshot 2025-03-11 at 4 24 48 PM

Maybe we call them this?

  • "Human-endpoint mapping"
  • "Human-endpoint mapping (IdP groups)"

That way, users shopping around will realize they can do mapping for free but they have to pay to get IdP groups mapped.

Copy link
Member

@noahtalerman noahtalerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some feedback re permissions and pricing.

Also, I updated this PR to "Ready for review" to @rachaelshaw knows the API changes are ready for review.

@noahtalerman noahtalerman marked this pull request as ready for review March 11, 2025 20:28
Copy link
Member

@rachaelshaw rachaelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants