-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deploy-fleet.md #26935
Update deploy-fleet.md #26935
Conversation
Remove settings that aren't minimally required to make it simpler to follow along @rfairburn @edwardsb @lukeheath Y'all, please stop me if this is a bad idea.
@mikermcneil if we are using the If we don't want to use
Or we could just leave them commented out in the example so they can be optionally added and then remove those lines in the documentation. Let me know, and I can update the example this is based on to make s3 carves off by default. |
@rfairburn I like your idea of removing from the docs but leaving commented out in the example. Simplifies the docs without losing the example. |
@lukeheath I will make the change to the example and link the PR here so we can make sure it's in place prior to changing the docs. |
Got it. @rachaelshaw @noahtalerman Since carves are not required for every instance, it sounds like we can put this (and anything else like it) at the bottom, simplifying everyday deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With fleetdm/fleet-terraform#15 in place, this should be approved.
Remove settings that aren't minimally required to make it simpler to follow along
@rfairburn @edwardsb @lukeheath Y'all, please stop me if this is a bad idea.