Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy-fleet.md #26935

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Update deploy-fleet.md #26935

merged 1 commit into from
Mar 11, 2025

Conversation

mikermcneil
Copy link
Member

Remove settings that aren't minimally required to make it simpler to follow along

@rfairburn @edwardsb @lukeheath Y'all, please stop me if this is a bad idea.

Remove settings that aren't minimally required to make it simpler to follow along


@rfairburn @edwardsb @lukeheath  Y'all, please stop me if this is a bad idea.
@mikermcneil mikermcneil marked this pull request as ready for review March 7, 2025 00:16
@mikermcneil mikermcneil requested a review from rachaelshaw as a code owner March 7, 2025 00:16
@rfairburn
Copy link
Contributor

@mikermcneil if we are using the osquery-carve module at all, these values must be set as they have to be universally unique across all of AWS and therefore cannot be optional.

If we don't want to use osquery-carve in our reference architecture, we can remove these sections:

Or we could just leave them commented out in the example so they can be optionally added and then remove those lines in the documentation.

Let me know, and I can update the example this is based on to make s3 carves off by default.

@lukeheath
Copy link
Member

@rfairburn I like your idea of removing from the docs but leaving commented out in the example. Simplifies the docs without losing the example.

@rfairburn
Copy link
Contributor

@lukeheath I will make the change to the example and link the PR here so we can make sure it's in place prior to changing the docs.

@mikermcneil
Copy link
Member Author

@mikermcneil if we are using the osquery-carve module at all, these values must be set as they have to be universally unique across all of AWS and therefore cannot be optional.

If we don't want to use osquery-carve in our reference architecture, we can remove these sections:

Or we could just leave them commented out in the example so they can be optionally added and then remove those lines in the documentation.

Let me know, and I can update the example this is based on to make s3 carves off by default.

Got it. @rachaelshaw @noahtalerman Since carves are not required for every instance, it sounds like we can put this (and anything else like it) at the bottom, simplifying everyday deployment.

Copy link
Contributor

@rfairburn rfairburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With fleetdm/fleet-terraform#15 in place, this should be approved.

@rachaelshaw rachaelshaw merged commit 97696cc into main Mar 11, 2025
5 checks passed
@rachaelshaw rachaelshaw deleted the mikermcneil-patch-27 branch March 11, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants