Water/LiquidOperatingCondition interface #780
Open
+533
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-flex
reviewed
Feb 28, 2025
flow360/component/simulation/operating_condition/operating_condition.py
Outdated
Show resolved
Hide resolved
benflexcompute
force-pushed
the
BenY/WaterInterface
branch
from
b843c18 to
6e0ad96
Compare
…lation, need to add unit test for the validations
|
|
||
|
|
||
| # def test_liquid_simulation_translation(): | ||
| # # Note: Maybe having this as one of the local test input? |
There was a problem hiding this comment.
Will we add the test in this or another PR?
There was a problem hiding this comment.
Good point. We will.
There was a problem hiding this comment.
I think at some point by end of the week in the nest PR we can add it.
There was a problem hiding this comment.
OK! I will leave the comment open in case we forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.